[CRIU] [PATCH 0/6] use core->tc->signals_s and core->thread_core->signals_p instead of signal-p/s*.img

[Pavel Emelyanov]

On 08/15/2014 05:02 PM, Ruslan Kuprieiev wrote:
> Currently shared and private signals are stored in signal-p/s*.img.
> In order to minimize the number of imgs, lets use core*.img to store signals.
> This patch saves backward compatibility, so criu will be able to use
> signal-p/s*.img if no signals_* are found.
> 
> Ruslan Kuprieiev (6):
>   protobuf: add signal_queue_entry
>   restore: open cores for each thread early and store them at
>     current->core
>   restore: use signals_s and signals_p to prepare signals
>   dump: allocate task cores in collect_task() instead of
>     parasite_infect_seized()
>   dump: dump signals into signals_*
>   image: mark CR_FD_SIGNAL and CR_FD_PSIGNAL as obsoleted and don't
>     create signal-s.img
> 
>  cr-dump.c              |  76 +++++++++++++++++----------------
>  cr-restore.c           | 114 ++++++++++++++++++++++++++++++++++++++-----------
>  include/image-desc.h   |   5 ++-
>  parasite-syscall.c     |   3 --
>  protobuf/core.proto    |   6 +++
>  protobuf/siginfo.proto |   4 ++
>  6 files changed, 141 insertions(+), 67 deletions(-)
> 

I like the patches. Run all the set through linux/scripts/checkpatch.pl, there 
are some coding style errors, and:

> @@ -17,9 +17,10 @@ enum {
>  	CR_FD_SIGACT,
>  	CR_FD_CREDS,
>  	CR_FD_FS,
> -	CR_FD_SIGNAL,
>  	_CR_FD_TASK_TO,
>  
> +	CR_FD_SIGNAL,/*obsoleted*/
> +
>  	CR_FD_PAGEMAP,
>  
>  	/*
> @@ -81,7 +82,7 @@ enum {
>  	CR_FD_TMPFS_IMG,
>  	CR_FD_TMPFS_DEV,
>  	CR_FD_PAGES,
> -	CR_FD_PSIGNAL,
> +	CR_FD_PSIGNAL,/*obsoleted*/
>  
>  	CR_FD_VMAS,
>  	CR_FD_PAGES_OLD,

Move both at the tail of the array.

Thanks,
Pavel