[CRIU] [PATCH 3/7] protobuf: add signals entry to thread_core_entry
Ruslan Kuprieiev
kupruser at gmail.com
Fri Aug 15 04:57:33 PDT 2014
15.08.2014 14:51, Pavel Emelyanov пишет:
> On 08/14/2014 06:33 AM, Ruslan Kuprieiev wrote:
>
> All protobuf changes are better to be in one patch.
>
>> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
>> ---
>> protobuf/core.proto | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/protobuf/core.proto b/protobuf/core.proto
>> index d850e2e..2844fb7 100644
>> --- a/protobuf/core.proto
>> +++ b/protobuf/core.proto
>> @@ -5,6 +5,8 @@ import "core-aarch64.proto";
>> import "rlimit.proto";
>> import "timer.proto";
>>
>> +import "siginfo.proto";
>> +
>> message task_core_entry {
>> required uint32 task_state = 1;
>> required uint32 exit_code = 2;
>> @@ -49,6 +51,7 @@ message thread_core_entry {
>> optional uint64 blk_sigset = 6;
>> optional thread_sas_entry sas = 7;
>> optional uint32 pdeath_sig = 8;
>> + optional signals_entry signals = 9;
> Why not put private signal_queue_entry in tread_core_entry and
> shared signal_queue_entry in task_core_entry? This would be
> easier to understand and one protobuf object less.
>
You won't believe, but it was my first thought=).
You are right, it will be better to do so.
Thanks.
>> }
>>
>> message task_rlimits_entry {
>>
More information about the CRIU
mailing list