[CRIU] [PATCH] restore: Set CLONE_PARENT iif pdeath_sig is present, v3

Pavel Emelyanov xemul at parallels.com
Thu Aug 14 10:59:03 PDT 2014


On 08/14/2014 09:40 PM, Cyrill Gorcunov wrote:
> On Thu, Aug 14, 2014 at 09:31:21PM +0400, Andrew Vagin wrote:
>>>  static inline int fork_with_pid(struct pstree_item *item)
>>>  {
>>>  	int ret = -1, fd;
>>> @@ -951,6 +985,8 @@ static inline int fork_with_pid(struct pstree_item *item)
>>>  			pr_err("Unknown task state %d\n", item->state);
>>>  			return -1;
>>>  		}
>>> +
>>> +		maybe_clone_parent(item, &ca);
>>
>> I think we need to execute this function only for the root task, doesn't
>> we?
> 
> yes, and we do. I move condition one level up for clarity, attached.
> 

1. A hunk in criu_signals_setup() is also required
2. CLONE_PARENT for swrk_restore is required even if no pdeath_sig present



More information about the CRIU mailing list