[CRIU] Bad commit

Pavel Emelyanov xemul at parallels.com
Thu Aug 14 07:26:56 PDT 2014


On 08/14/2014 06:24 PM, Cyrill Gorcunov wrote:
> On Thu, Aug 14, 2014 at 06:19:55PM +0400, Pavel Emelyanov wrote:
>>>>
>>>> OTOH we need this CLONE_PARENT trick only when the root task has the
>>>> pdeath_sig set up. Can we relax the if () to only do the CLONE_PARENT
>>>> if the detach is requested and pdeath_sig is set up?
>>>
>>> you mean to walk over thread_core->pdeath_sig entries to find if it's set?
>>
>> Now walk, just check the one at root task. Do we have the core entry
>> ready at that point?
> 
> Nope. We read core just in fork_with_pid :)

Pity :( I believe we can afford reading the core before fork() at least
for the root task :)

Thanks,
Pavel



More information about the CRIU mailing list