[CRIU] Bad commit

Pavel Emelyanov xemul at parallels.com
Thu Aug 14 07:19:55 PDT 2014


On 08/14/2014 06:11 PM, Cyrill Gorcunov wrote:
> On Thu, Aug 14, 2014 at 06:05:51PM +0400, Pavel Emelyanov wrote:
>>>
>>> Yeah, sorry for noise.
>>
>> Wait a second, this code was in 3.12 and (probably) earlier:
>> commit 1f7f4dde5c945f41a7abc2285be43d918029ecc5 removed CLONE_PARENT
>> and it appeared in 
>>
>> $ git describe 1f7f4dde5c945f41a7abc2285be43d918029ecc5
>> v3.13-rc1-130-g1f7f4dd
>>
>> IOW -- --restore-detach with CLONE_NEWPID will fail when criu is run
>> on 3.11, which we recommend as the base kernel.
>>
>> OTOH we need this CLONE_PARENT trick only when the root task has the
>> pdeath_sig set up. Can we relax the if () to only do the CLONE_PARENT
>> if the detach is requested and pdeath_sig is set up?
> 
> you mean to walk over thread_core->pdeath_sig entries to find if it's set?

Now walk, just check the one at root task. Do we have the core entry
ready at that point?

Thanks,
Pavel




More information about the CRIU mailing list