[CRIU] [PATCH] zdtm: add a small program to create a zdtm container

Christopher Covington cov at codeaurora.org
Thu Aug 14 06:26:26 PDT 2014


On 08/14/2014 09:23 AM, Andrew Vagin wrote:
> On Wed, Aug 13, 2014 at 11:40:44PM +0400, Pavel Emelyanov wrote:
>>>>> Why not simply move the contents of test/zdtm_ct.c into crtools.c, executed
>>>>> conditionally based on -n, --namespace, and call it initially implemented?
>>>>
>>>> This is because creating a namespace typically requires setting one up.
>>>> E.g. if we want to put the restored tree into pid namespace, we should
>>>> provide an init task, because root task in images doesn't have pid 1.
>>>> If we want to restore tasks into net namespace, while they previously
>>>> didn't live in it, we have to configure this new net namespace so that
>>>> e.g. sockets got restored properly.
>>>
>>> Doesn't the proposed code in test/zdtm_ct.c do these things?
>>
>> It does, but in a very specific way -- the minimally sufficient to zdtm.
> 
> Christopher, can we commit this patch? We can continue duscussing how
> to do something similar in CRIU. And when we will find a solution, we will
> remove this program.
> 
> Currently Jenkins waits this patch to continue testing CRIU.

Acked-by: Christopher Covington <cov at codeaurora.org>

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.


More information about the CRIU mailing list