[CRIU] [PATCH] zdtm: add a small program to create a zdtm container

Andrew Vagin avagin at parallels.com
Wed Aug 13 10:52:42 PDT 2014


On Wed, Aug 13, 2014 at 04:49:57PM +0000, Serge Hallyn wrote:
> Quoting Andrew Vagin (avagin at parallels.com):
> > On Wed, Aug 13, 2014 at 11:13:11AM +0400, Andrew Vagin wrote:
> > > On Tue, Aug 12, 2014 at 04:33:30PM +0000, Serge Hallyn wrote:
> > > > Quoting Andrey Vagin (avagin at openvz.org):
> > > > > I didn't find a way how to do that with help "unshare".
> > > > > It's simpler to write this program. It looks better than tricks in
> > > > > zdtm.sh.
> > > > > 
> > > > > Signed-off-by: Andrey Vagin <avagin at openvz.org>
> > > > 
> > > > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> > > > 
> > > > Would it be worth verifying that the waited-upon process has the expected pid?
> > > 
> > > Serge, could you look at the attached version. If you will not have
> > > objections, I will send it with your acked-by.
> 
> Hi,
> 
> so is there any concern about system("ip ...") and corrupted paths, or do
> we trust the caller?

Yes, we do. This program is used only for executing tests.

> 
> Otherwise, it looks ok to me, unfamiliar as I am with the context code.

Thanks,
Andrew


More information about the CRIU mailing list