[CRIU] [PATCH] zdtm: add a small program to create a zdtm container

Andrew Vagin avagin at parallels.com
Wed Aug 13 04:00:59 PDT 2014


On Wed, Aug 13, 2014 at 11:13:11AM +0400, Andrew Vagin wrote:
> On Tue, Aug 12, 2014 at 04:33:30PM +0000, Serge Hallyn wrote:
> > Quoting Andrey Vagin (avagin at openvz.org):
> > > I didn't find a way how to do that with help "unshare".
> > > It's simpler to write this program. It looks better than tricks in
> > > zdtm.sh.
> > > 
> > > Signed-off-by: Andrey Vagin <avagin at openvz.org>
> > 
> > Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>
> > 
> > Would it be worth verifying that the waited-upon process has the expected pid?
> 
> Serge, could you look at the attached version. If you will not have
> objections, I will send it with your acked-by.
> 
> Thanks.
> 

...

> --- a/test/Makefile
> +++ b/test/Makefile
> @@ -28,7 +28,13 @@ fault-injection: .FORCE
>  zdtm_ns: $(shell echo "$(TST)" | tr ' ' '\n' | grep -P $(EXP))
>  zdtm_nons: $(shell echo "$(TST)" | tr ' ' '\n' | grep -vP $(EXP))
>  
> +zdtm_ct: zdtm_ct.c
> +
> +clean:
> +	rm -rf zdtm_ct
> +	$(MAKE) -C zdtm $@
> +
>  $(TST):
> -	./zdtm.sh --ct ${ZDTM_ARGS} $(@) &> $(subst /,_,$@).log || \
> +	./zdtm.sh ${ZDTM_ARGS} $(@) &> $(subst /,_,$@).log || \

I don't know when I removed the --ct option. It is still required.
The updated patch is attached. Sorry for inconvenience.

>  	{ flock Makefile cat $(subst /,_,$@).log; exit 1; }
>  .PHONY: zdtm_ns


More information about the CRIU mailing list