[CRIU] [PATCH] opts: add --manage-cgroups option

Pavel Emelyanov xemul at parallels.com
Tue Aug 12 03:33:11 PDT 2014


On 08/06/2014 10:23 PM, Tycho Andersen wrote:
> On Wed, Aug 06, 2014 at 10:30:30AM +0400, Pavel Emelyanov wrote:
>> On 08/05/2014 09:07 AM, Tycho Andersen wrote:
>>> criu managed cgroups is now an opt-in thing, so by default criu does not manage
>>> (i.e. dump or restore) cgroups. This allows users to preserve the
>>> previous behavior.
>>
>> With this the zdtm's cgroup00 and cgroup01 both start to fail since
>> cgroups are not managed. You can specify options that should be passed
>> to criu dump/restore in per-test manner by putting them into $test.opts
>> files. E.g. look at test/zdtm/live/static/unlink_fstat03.opts
> 
> Ah, yes, sorry about that.
> 
>> And one more thing:
>>
>>
>>> --- a/crtools.c
>>> +++ b/crtools.c
>>> @@ -167,6 +168,7 @@ int main(int argc, char *argv[])
>>>  		{ "force-irmap", no_argument, 0, 58},
>>>  		{ "ext-mount-map", required_argument, 0, 'M'},
>>>  		{ "exec-cmd", no_argument, 0, 59},
>>> +		{ "manage-cgroups", no_argument, 0, 60},
>>
>> Would you also add a line to the the --help message.
> 
> I just put it under "Special resources support", let me know if there
> is a better place.
> 
> Tycho
> 
> 
> 
> 
> criu managed cgroups is now an opt-in thing, so by default criu does not manage
> (i.e. dump or restore) cgroups. This allows users to use the previous behavior.
> 
> Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>

Applied, thanks!


More information about the CRIU mailing list