[CRIU] [PATCH 4/6] dump: dump signals before infecting with parasite

Ruslan Kuprieiev kupruser at gmail.com
Sun Aug 10 14:09:38 PDT 2014


Btw, this patch _by itself_ causes segfault, as cr_fdset isn't set 
properly yet.
After the whole set everything whould be ok, as cr_fdset whouldn't be used.
Sorry=(. The new set is coming up soon.

05.08.2014 11:35, Ruslan Kuprieiev пишет:
> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
> ---
>   cr-dump.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/cr-dump.c b/cr-dump.c
> index d8ad0fc..c8be0bd 100644
> --- a/cr-dump.c
> +++ b/cr-dump.c
> @@ -1498,6 +1498,12 @@ static int dump_one_task(struct pstree_item *item)
>   		goto err;
>   	}
>   
> +	ret = dump_task_signals(pid, item, cr_fdset);
> +	if (ret) {
> +		pr_err("Dump %d signals failed %d\n", pid, ret);
> +		goto err;
> +	}
> +
>   	ret = -1;
>   	parasite_ctl = parasite_infect_seized(pid, item, &vmas, dfds, proc_args.timer_n);
>   	if (!parasite_ctl) {
> @@ -1632,12 +1638,6 @@ static int dump_one_task(struct pstree_item *item)
>   		goto err;
>   	}
>   
> -	ret = dump_task_signals(pid, item, cr_fdset);
> -	if (ret) {
> -		pr_err("Dump %d signals failed %d\n", pid, ret);
> -		goto err;
> -	}
> -
>   	close_cr_fdset(&cr_fdset);
>   err:
>   	close_pid_proc();



More information about the CRIU mailing list