[CRIU] [PATCH] zdtm: add a dummy action-script

Pavel Emelyanov xemul at parallels.com
Thu Aug 7 06:14:40 PDT 2014


On 08/07/2014 04:16 PM, Christopher Covington wrote:
> On 08/07/2014 03:06 AM, Pavel Emelyanov wrote:
>> On 08/06/2014 05:05 PM, Andrey Vagin wrote:
>>> Just to be sure that it affects nothing
>>
>> This would affect the full tests run time significantly.
> 
> What if it went in at the same time as an optimization so that overall runtime
> stayed constant or dropped?

Hardly. The sigaction restore saves us 64 syscalls per-task for tests that have
more than one of them (quite a few), while each --action-script results in 3-4
system() calls performed :)

> Speaking of test run-time, it appears to me that zdtm.sh is currently pretty
> single threaded. Adding parallelization to the test harness may provide a
> useful speedup on quad code and greater systems (maybe the kind of speed up
> that could hide the slowdown of always running a script).

Andrew knows some way of launching ns/ tests in parallel. Andrey?

>> Can we add some randomization and feed the fake script into arbitrary 10%
>> of the tests?
> 
> Are the current tests generally deterministic? 

Yup.

> If so I think it'd be good to
> keep them so, for repeatably results and easy debugging. Probabilistic testing
> or fuzzing sounds like a great idea, but perhaps it'd be best organized as a
> separate suite from deterministic tests.

Yes, I agree. Maybe we can then pick some tests and add --action-scrip true
into the .opts file?

Thanks,
Pavel




More information about the CRIU mailing list