[CRIU] [PATCH] restore: restore sigaction for alive tasks

Andrew Vagin avagin at parallels.com
Thu Aug 7 01:08:34 PDT 2014


On Thu, Aug 07, 2014 at 11:53:35AM +0400, Pavel Emelyanov wrote:
> On 08/07/2014 11:50 AM, Andrew Vagin wrote:
> > Reported-by: Jenkins Criuovich
> > Signed-off-by: Andrew Vagin <avagin at openvz.org>
> > ---
> >  cr-restore.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/cr-restore.c b/cr-restore.c
> > index cb858c9..1b538e1 100644
> > --- a/cr-restore.c
> > +++ b/cr-restore.c
> > @@ -641,6 +641,12 @@ static int prepare_sigactions(void)
> >  	int sig, rst = 0;
> >  	int ret = 0;
> >  
> > +	switch (current->state) {
> > +	case TASK_HELPER:
> 
> HELPER's child will have the parent_sigacts array "spoiled" :(

No, it will not.

The helper task doesn't change sigaction and does nothing with
parent_sigacts. paren_sigacts will contain values for the previous alive
task, so the logic about inherence should work as expected.

> 
> > +	case TASK_DEAD:
> > +		return 0;
> > +	}
> > +
> >  	pr_info("Restore sigacts for %d\n", pid);
> >  
> >  	fd_sigact = open_image(CR_FD_SIGACT, O_RSTR, pid);
> > 
> 


More information about the CRIU mailing list