[CRIU] [PATCH 1/2] Copy x86 VDSO code to AArch64

Pavel Emelyanov xemul at parallels.com
Wed Aug 6 04:59:32 PDT 2014


On 08/06/2014 03:55 PM, Cyrill Gorcunov wrote:
> On Wed, Aug 06, 2014 at 07:52:27AM -0400, Christopher Covington wrote:
>> On 08/06/2014 02:09 AM, Cyrill Gorcunov wrote:
>>> On Tue, Aug 05, 2014 at 04:20:23PM -0400, Christopher Covington wrote:
>>>> I don't like duplicating hundreds of lines of code, but it's
>>>> what Cyrill wants [1].
>>>>
>>>> 1. http://lists.openvz.org/pipermail/criu/2014-August/015218.html
>>>>
>>>> Signed-off-by: Christopher Covington <cov at codeaurora.org>
>>> Acked-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>>
>>> Maybe I will manage to come with some general but still flexible
>>> solution, for a while lets keep code separated
>>
>> Should I resubmit with a better commit message? When I was writing it I may
>> have been thinking that submitting the patch signaled a certain level of
>> agreement with your approach.
>>
>> As time allows I'd like to look into it as well, maybe going after the kernel
>> code first, which as you've pointed out has significant per-architecture portions.
> 
> Up to Pavel. If he is not yet merged this patch, then I presume more detailed
> commit changelog would be preferred.

The existing message suits me. So up to you, guys :) Once we have problems
with VDSO I'll ping you and you'll have to remember what is and was going 
on there ;)

I'm fine if you just send me some text, that should be added to the comment
instead of resubmitting the whole patch.

Thanks,
Pavel



More information about the CRIU mailing list