[CRIU] [PATCH 2/6] protobuf: siginfo.proto: add signals_entry

[Ruslan Kuprieiev]

06.08.2014 11:07, Pavel Emelyanov пишет:
> On 08/06/2014 12:00 PM, Ruslan Kuprieiev wrote:
>> 06.08.2014 09:58, Pavel Emelyanov пишет:
>>> On 08/05/2014 12:35 PM, Ruslan Kuprieiev wrote:
>>>> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
>>>> ---
>>>>    protobuf/siginfo.proto | 5 +++++
>>>>    1 file changed, 5 insertions(+)
>>>>
>>>> diff --git a/protobuf/siginfo.proto b/protobuf/siginfo.proto
>>>> index c3630f9..35b3752 100644
>>>> --- a/protobuf/siginfo.proto
>>>> +++ b/protobuf/siginfo.proto
>>>> @@ -5,3 +5,8 @@ message siginfo_entry {
>>>>    message signal_queue_entry {
>>>>    	repeated siginfo_entry signals = 1;
>>>>    }
>>>> +
>>>> +message signals_entry {
>>>> +	optional signal_queue_entry shared = 1;
>>>> +	repeated signal_queue_entry private = 2;
>>> Why repeated?
>> Because it contains signals for every thread.
>> I did try to spread private signals across thread cores, but that
>> turn out to be ugly, and not so logically correct as it might seem to be.
> And you map thread to signal_queue_entry simply by index match?
> Such things are not good to have in the images.
>
> Signals should be in thread_core-s, yes, why do you say it's wrong?

I'm not saying that it's wrong, i'm saying that it required some changes
that I considered a bit ugly=).
But I understand the issue. Will fix.
Thanks=).