[CRIU] [PATCH 1/2] Quick bug fix for move_in_cgroup() missing fd

[Pavel Emelyanov]

On 08/05/2014 11:50 PM, gbellack at google.com wrote:
> From: gbellack <gbellack at google.com>
> 
> There is an issue where if the proccess to be killed spawns a child proccess and
> moves it in a child cgroup of the one the parent proccess is in, upon restore,
> move_in_cgroup() is called twice as it should be (once to move the parent
> proccess and once to move the child proccess) but the file descriptor has
> already been closed causing a failure for the second call to move_in_cgroup().

Can you provide more details please? The move_in_cgroup() is supposed to
move task only once, how does the 2nd time happen?

> Change-Id: I6ae88b95c5410a7f56108e28eb3133f113e868d0
> Signed-off-by: Garrison Bellack <gbellack at google.com>
> ---
>  cgroup.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/cgroup.c b/cgroup.c
> index 06311e4..8c99e9d 100644
> --- a/cgroup.c
> +++ b/cgroup.c
> @@ -617,7 +617,6 @@ static int move_in_cgroup(CgSetEntry *se)
>  		}
>  	}
>  
> -	close_service_fd(CGROUP_YARD);
>  	return 0;
>  }
>  
>