[CRIU] [PATCH] opts: add --no-restore-cgroup option

[Tycho Andersen]

On Mon, Aug 04, 2014 at 09:08:49AM -0700, Saied Kazemi wrote:
> Yes, in practice it would be the responsibility of an "agent" (Docker, LXC,
> migration agent, etc.) to create the cgroups before attempting to restore
> the process.  In fact if restore is done on a different machine, the
> cgroups properties of the source machine may not even apply on the
> destination machine.
> 
> That said, I think we can/should do without --no-restore-cgroup option
> because the cgroups restore logic in CRIU should detect that everything is
> already setup and there is no need for it to do anything (effectively it
> becomes a noop).

Agreed, and I think that the code in the current master should be a
no-op if everything already exists.

Tycho

> In short, CRIU usage will be easier with less options.
> 
> --Saied
> 
> 
> 
> On Mon, Aug 4, 2014 at 8:08 AM, Cyrill Gorcunov <gorcunov at gmail.com> wrote:
> 
> > On Mon, Aug 04, 2014 at 09:59:01AM -0500, Tycho Andersen wrote:
> > >
> > > Users may already be restoring their own cgroups; now that criu does
> > this,
> > > those users may want to turn criu's version off until/unless they
> > migrate.
> >
> > Thanks for changelog! I'm not really following the reallife scenario
> > though.
> > Up to Pavel the rest.
> > _______________________________________________
> > CRIU mailing list
> > CRIU at openvz.org
> > https://lists.openvz.org/mailman/listinfo/criu
> >