[CRIU] --restore-detached & service restore problems?

[Pavel Emelyanov]

On 08/04/2014 06:47 PM, Tycho Andersen wrote:
> Hi Pavel,
> 
> On Mon, Aug 04, 2014 at 12:29:01PM +0400, Pavel Emelyanov wrote:
>> On 08/01/2014 09:03 PM, Tycho Andersen wrote:
>>> Hi all,
>>
>> Hi, Tycho.
>>
>> If this is still relevant:
>>
>>> I'm having trouble running criu with --restore-detached or via the
>>> service/rpc. When I run criu without --restore-detached, everything
>>> works as expected, but when I run it with, criu seems to fork and
>>> restore all the processes, and then they promptly exit (or die, not
>>> sure) when the restore is done. The log is normal as far as I can
>>> tell.
>>>
>>> Has anyone else experienced this? Any ideas as to what is going on?
>>
>> When restoring via service the --restore-detached is forced into true,
>> so that what is being restored doesn't live as service's child.
> 
> Yeah, that is what I guessed. I suppose they are caused by the same
> thing?

Most likely yes.

>> As far as CLI usage, this can be due to pdeath_sig :( Can you check
>> whether the root task contains one in the core image?
> 
> Yes, it does. Is there an easy way to work around this?

Well, I've fixed this for criu_restore_child() call -- grep for swrk_restore
over the criu code (a couple of places), I suppose the same trick should
be used for detached restore.


Thanks,
Pavel