[CRIU] [PATCH 3/6] lib: Generate pkgconfig file

Pavel Emelyanov xemul at parallels.com
Mon Aug 4 02:57:46 PDT 2014


On 07/31/2014 09:42 PM, Serge Hallyn wrote:
> Quoting Tycho Andersen (tycho.andersen at canonical.com):
>> On Wed, Jul 30, 2014 at 03:37:18PM +0000, Serge Hallyn wrote:
>>> Quoting Tycho Andersen (tycho.andersen at canonical.com):
>>>>
>>>> Yes, so it is essentially that. Perhaps I don't understand what the
>>>> purpose of $DESTDIR is, then. I guess you don't want it in the
>>>> pkgconfig because the pkgconfig is supposed to be relative to --prefix
>>>> only?
>>>
>>> Right.  $prefix is where relative to / you want the binaries installed.
>>> $DESTDIR is where to do the make install, for the sake of creating a
>>> tarfile or copying later.  The .pc file should -iiuc - have the paths
>>> relative to the final install location of binaries, which is just
>>> $prefix.
>>
>> Ah ha, makes sense. In that case, the updated patch is below.
>>
>>>> (The confusion here is that users can't really set PREFIX, so you have
>>>
>>> can't they specify prefix through configure --prefix=?
>>
>> No, because criu doesn't have a ./configure.
>>
>> Tycho
>>
>>
>>
>>
>> Signed-off-by: Tycho Andersen <tycho.andersen at canonical.com>
> 
> Acked-by: Serge E. Hallyn <serge.hallyn at ubuntu.com>

Applied, thanks guys!



More information about the CRIU mailing list