[CRIU] [PATCH 1/2] DO NOT MERGE: Move x86 VDSO code to AArch64

Christopher Covington cov at codeaurora.org
Fri Aug 1 09:04:05 PDT 2014


On 08/01/2014 11:47 AM, Cyrill Gorcunov wrote:
> On Fri, Aug 01, 2014 at 11:37:01AM -0400, Christopher Covington wrote:
>>
>> What makes you predict the code will become more different between
>> architectures? The interactions I've seen on the Linux kernel mailing lists
>> indicate that the developers (Andy, Will) are now working more closely with
>> each other and their changes are making things more similar across architectures.
> 
> I just think so. We already been there when I've cnagned vdso handling (and
> result was that it worked on x86 but failed on arm).

When was this? Are you talking about

commit c473461d24fdfcd25542b427829a37fd2f0facb5
vdso: Make it arch specific

> Moreover we always will have a chance to merge source code but if we merge
> it too early this will become pain in *ss to unsplit it back.
> 
>>>   So, I think
>>>
>>>  - copy the files you need into ARM's arch
>>>  - tune them up to be workable on ARM
>>>
>>> this is safest from my POV.
>>
>> I'll submit patches like this in the sort term, based on your vdso/vvar
>> re-ordering series. Are there any changes needed to them before they can be
>> merged?
> 
> None I think of. I guess once you have it worked well on arm it might be
> a single commit with all files merged in.

When do you expect to merge the patches for x86_64?

Thanks,
Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.


More information about the CRIU mailing list