[CRIU] [PATCH 2/2] Have mountinfo use temporary procfs

Pavel Emelyanov xemul at parallels.com
Fri Apr 25 02:30:55 PDT 2014


On 04/25/2014 12:54 AM, Christopher Covington wrote:
> This allows restoring processes inside brand new namespaces that
> don't have a procfs already mounted such as from the following
> commands.
> 
> unshare -fp -- criu restore
> 
> Signed-off-by: Christopher Covington <cov at codeaurora.org>
> ---
>  cr-restore.c | 6 +++---
>  proc_parse.c | 7 ++-----
>  2 files changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/cr-restore.c b/cr-restore.c
> index 584e1dc..f230692 100644
> --- a/cr-restore.c
> +++ b/cr-restore.c
> @@ -1246,9 +1246,6 @@ static int restore_task_with_children(void *_arg)
>  		if (restore_finish_stage(CR_STATE_RESTORE_NS) < 0)
>  			exit(1);
>  
> -		if (collect_mount_info(getpid()))
> -			exit(1);
> -

With multiple mount namespaces patches merged, the old mountinfo-s are now
collected in prepare_namespaces(). Would you re-base this patch on the
recent changes?

I planned to tag 1.3-rc1 today to let people play with mount namespaces and
aarch64 support, so this will get merged after the -rc1. But will get into
the final 1.3 release.

>  		if (prepare_namespace(current, ca->clone_flags))
>  			exit(1);
>  

Thanks,
Pavel


More information about the CRIU mailing list