[CRIU] [PATCH] kcmp: Fix ret code comparison, v2

Cyrill Gorcunov gorcunov at gmail.com
Mon Apr 21 23:37:22 PDT 2014


On Tue, Apr 22, 2014 at 10:31:13AM +0400, Cyrill Gorcunov wrote:
> On Tue, Apr 22, 2014 at 08:43:03AM +0400, Andrew Vagin wrote:
> > > @@ -149,12 +149,14 @@ static u32 kid_generate_sub(struct kid_tree *tree, struct kid_entry *e,
> > >  				this->elem.idx, elem->idx);
> > >  
> > >  		parent = *new;
> > > -		if (ret < 0)
> > Can we print an error here?
> > 			pr_perror("Unable to compare (%d, %x) %x (%d, %x)", ....)
> 
> Sure, I guess instead of BUG better to exit with error. Will update, thanks.

Attached.


More information about the CRIU mailing list