[CRIU] [PATCH 02/39] mounts: initialize root before dumping mount namespace

Pavel Emelyanov xemul at parallels.com
Mon Apr 21 11:21:29 PDT 2014


On 04/21/2014 06:23 PM, Andrey Vagin wrote:
> Currently it's initialized for the root mount namespace, but we are
> going to dump nested mount namespaces.
> 
> It's used in open_mountpoint(), which is used in dump_tmpfs() and in
> other callbacks.

The mntns root is also required in dumping files, but the
fn you put the collect to is executed in a subprocess. How
are we going to deal with that?

> Signed-off-by: Andrey Vagin <avagin at openvz.org>
> ---
>  mount.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/mount.c b/mount.c
> index 93b3fe3..91a3e3c 100644
> --- a/mount.c
> +++ b/mount.c
> @@ -821,6 +821,9 @@ int dump_mnt_ns(int ns_pid, int ns_id)
>  	if (img_fd < 0)
>  		return -1;
>  
> +	if (mntns_collect_root(ns_pid))
> +		goto err;
> +
>  	pm = parse_mountinfo(ns_pid);
>  	if (!pm) {
>  		pr_err("Can't parse %d's mountinfo\n", ns_pid);
> 




More information about the CRIU mailing list