[CRIU] [PATCH 4/4] mount: open_mount uses __open_mountpoint instead of own logic

Pavel Emelyanov xemul at parallels.com
Tue Apr 15 14:38:14 PDT 2014


On 04/15/2014 12:31 PM, Andrey Vagin wrote:

This comment sucks.

> Signed-off-by: Andrey Vagin <avagin at openvz.org>

> @@ -488,7 +476,7 @@ static int __open_mountpoint(struct mount_info *pm, int mnt_fd)
>  
>  		mntns_root = get_service_fd(ROOT_FD_OFF);
>  
> -		snprintf(path, sizeof(path), ".%s", pm->mountpoint);
> +		snprintf(path, sizeof(path), "./%s", pm->mountpoint);

Why is this hunk here?

>  		mnt_fd = openat(mntns_root, path, O_RDONLY);
>  		if (mnt_fd < 0) {
>  			pr_perror("Can't open %s", pm->mountpoint);
> 




More information about the CRIU mailing list