[CRIU] [PATCH 1/4] Make sure logrotate directory exists

Christopher Covington cov at codeaurora.org
Fri Apr 11 05:32:14 PDT 2014


Hi Pavel,

On 04/11/2014 07:18 AM, Pavel Emelyanov wrote:
> On 04/09/2014 07:13 PM, Christopher Covington wrote:
>> Otherwise, `make install` may fail.
>>
>> Signed-off-by: Christopher Covington <cov at codeaurora.org>
>> ---
>>  Makefile | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Makefile b/Makefile
>> index 7e192ad..7900b91 100644
>> --- a/Makefile
>> +++ b/Makefile
>> @@ -265,6 +265,7 @@ install: $(PROGRAM) install-man
>>  	$(Q) mkdir -p $(DESTDIR)$(SYSTEMDUNITDIR)
>>  	$(Q) install -m 644 scripts/sd/criu.socket $(DESTDIR)$(SYSTEMDUNITDIR)
>>  	$(Q) install -m 644 scripts/sd/criu.service $(DESTDIR)$(SYSTEMDUNITDIR)
>> +	$(Q) mkdir -p $(DESTDIR)$(LOGROTATEDIR)
>>  	$(Q) install -m 644 scripts/logrotate.d/criu-service $(DESTDIR)$(LOGROTATEDIR)
>>  
>>  install-man:
> 
> 1 through 3 applied, thanks.

Thank you.

> Christopher, with the patch #2 merged -- can you consider adding a test
> into zdtm/ suite to check that stopped multithreaded tasks are C/R-d well?

Yes, I'd like to write a test for that, as well as `criu restore --exec-cmd --
perf stat`, but I've first got to either get ZDTM building in my ARM/ARM64
cross-compilation environment or get a recent x86_64 kernel built and running
on QEMU.

Christopher

-- 
Employee of Qualcomm Innovation Center, Inc.
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by the Linux Foundation.


More information about the CRIU mailing list