[CRIU] [PATCH 2/5] rpc: rename criu_dump_resp to criu_opts and add restore type of req

Pavel Emelyanov xemul at parallels.com
Mon Sep 30 07:09:59 PDT 2013


On 09/30/2013 05:48 PM, Andrew Vagin wrote:
> On Mon, Sep 30, 2013 at 03:06:23PM +0400, Ruslan Kuprieiev wrote:
>> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
> 
>> ---
>> diff --git a/protobuf/rpc.proto b/protobuf/rpc.proto
>> index a07b05f..1ce6d49 100644
>> --- a/protobuf/rpc.proto
>> +++ b/protobuf/rpc.proto
>> @@ -1,6 +1,6 @@
>> -message criu_dump_req {
>> +message criu_opts {
>>  	required int32 images_dir_fd	= 1;
>> -	optional int32 pid		= 2; //if not set, will dump requesting process
>> +	optional int32 pid		= 2; //if not set on dump, will dump requesting process
>>  
>>  	optional bool leave_running	= 3;
>>  	optional bool ext_unix_sk	= 4;
>> @@ -8,16 +8,22 @@ message criu_dump_req {
>>  	optional bool evasive_devices	= 6;
>>  	optional bool shell_job		= 7;
>>  	optional bool file_locks	= 8;
>> -	optional int32 log_level	= 9 [default = 2];
>> +	optional string log_file	= 9;
>> +	optional int32 log_level	= 10 [default = 2];
>>  }
> 
> Do you understand, that you break backward compatibility?

rpc is not yet released, thus he doesn't.


More information about the CRIU mailing list