[CRIU] [PATCH] restorer: rework unmaping old VMA-s

[Andrew Vagin]

On Fri, Sep 20, 2013 at 07:03:15PM +0400, Cyrill Gorcunov wrote:
> On Fri, Sep 20, 2013 at 06:43:14PM +0400, Cyrill Gorcunov wrote:
> > > 
> > > Signed-off-by: Andrey Vagin <avagin at openvz.org>
> > 
> > Looks like it should do the trick, thanks! (I was mostly worried about vdso
> > area but it is fine as far as i see).
> 
> Btw, this snippet
> 
> static int unmap_old_vmas(void *premmapped_addr, unsigned long premmapped_len,
> 		      void *bootstrap_start, unsigned long bootstrap_len)
> {
> 	void *p[6] = {NULL, 0, 0, 0, 0, (void *) TASK_SIZE};
> ...
> 	for (i = 0; i < 6; i += 2) {
> should be < 5 i think

I think you don't notice that "i+= 2", so here is no difference between
5 or 6.

> 		ret = sys_munmap(p[i], p[i + 1] - p[i]);
> }
> 
>