[CRIU] [PATCHv6 2/6] protobuf: rpc.proto

[Pavel Emelyanov]

On 09/12/2013 02:44 PM, Ruslan Kuprieiev wrote:
> On 09/12/2013 02:09 PM, Pavel Emelyanov wrote:
>> On 09/12/2013 01:00 AM, Ruslan Kuprieiev wrote:
>>> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>
>> OK, let's polish the RPC itself.
>>
>>> @@ -0,0 +1,18 @@
>>> +message criu_dump_req {
>> Now let's imagine we have another request type to criu service.
>> How would we send one?
>>
> What other requests are planned?

As usually -- we don't know, but the construction we make should allow for this.

> Maybe we do need to add some protobuf header with type, and send it 
> before sending request?

There are three options:

1. do as you propose -- two pb messages, 1st one with req type, probably criu
   version, maybe smth else, the 2nd one with the dump request args

2. is basically the same with one exception -- the 2nd message is put onto the
   1st one as an optional pb field

I think the 2nd way would be simpler.