[CRIU] [PATCHv6 2/6] protobuf: rpc.proto

[Pavel Emelyanov]

On 09/12/2013 01:00 AM, Ruslan Kuprieiev wrote:
> Signed-off-by: Ruslan Kuprieiev <kupruser at gmail.com>

OK, let's polish the RPC itself.

> @@ -0,0 +1,18 @@
> +message criu_dump_req {

Now let's imagine we have another request type to criu service.
How would we send one?

> +	//
> +	// FIXME Add more arguments.

This comment is excessive.

> +	//
> +	required int32 pid		= 1; //if not set, will dump requesting process
> +	required bool leave_running	= 2;
> +	required bool ext_unix_sk	= 3;
> +	required bool tcp_established	= 4;
> +	required bool evasive_devices	= 5;
> +	required bool shell_job		= 6;
> +	required bool file_locks	= 7;
> +	required int32 images_dir_fd	= 8;
> +	required int32 log_level	= 9 [default = 2];
> +}
> +
> +message criu_dump_resp {
> +	required bool success		= 1;

This resp lacks info about whether we dumped the task or resumed one.

> +}
>