[CRIU] [PATCHv5 3/3] crtools: cr_service() meat and a few fixes to properly dump cr_service socket

[Ruslan Kuprieiev]

On 09/09/2013 10:51 PM, Pavel Emelyanov wrote:
> On 09/09/2013 04:30 PM, Ruslan Kuprieiev wrote:
>> +		pr_perror("Can't stat images direcrtory");
>> +		goto err;
>> +	}
>> +
>> +	if (ids.uid == st.st_uid || ids.gid == st.st_gid || ids.uid == 0) {
> This check is pointless. Kernel would do it itself properly.

But criu will open dir as root. And here we are checking if client has 
permissions to write to this directory.

> I think in RPC we should use raw pb messages w/o u32 size-s pb_foo 
> engine adds. 

Why? Isn't sending sizes of msgs good?