[CRIU] [PATCHv5 2/3] protobuf: .proto files for dump request and response

[Pavel Emelyanov]

On 09/09/2013 04:13 PM, Ruslan Kuprieiev wrote:
> Signed-off-by: Ruslan Kuprieiev kupruser at gmail.com

Mail should be in <>-s.

> 
> --- /dev/null
> +++ b/protobuf/criu-dump-req.proto
> @@ -0,0 +1,14 @@
> +message criu_dump_req {
> +	//
> +	// FIXME Add more arguments.
> +	//
> +	required int32 pid		= 1 [default = -1];

default 0 is enough.

> +	required bool leave_running	= 2 [default = false];
> +	required bool ext_unix_sk	= 3 [default = false];
> +	required bool tcp_established	= 4 [default = false];
> +	required bool evasive_devices	= 5 [default = false];
> +	required bool shell_job		= 6 [default = false];
> +	required bool file_locks	= 7 [default = false];

1. default-s are useless for required fields.
2. default defaults are excessive (false for bool is such)

> +	required string images_dir	= 8;
> +	required int32 log_level	= 9 [default = 2];
> +}
> diff --git a/protobuf/criu-dump-resp.proto b/protobuf/criu-dump-resp.proto
> new file mode 100644
> index 0000000..031683a
> --- /dev/null
> +++ b/protobuf/criu-dump-resp.proto
> @@ -0,0 +1,4 @@
> +message criu_dump_resp {
> +	required bool success		= 1 [default = false];
> +	required bool bad_args		= 2 [default = false];
> +}

Plz, put them all into one file called rpc.proto

> 
>