[CRIU] [PATCH] restore: Don't unmap vdso proxy on final cleanup

Cyrill Gorcunov gorcunov at gmail.com
Wed Oct 30 05:24:31 PDT 2013


On Wed, Oct 30, 2013 at 04:10:56PM +0400, Andrew Vagin wrote:
> > diff --git a/cr-restore.c b/cr-restore.c
> > index e219bca..eca540a 100644
> > --- a/cr-restore.c
> > +++ b/cr-restore.c
> > @@ -2395,6 +2395,7 @@ static int sigreturn_restore(pid_t pid, CoreEntry *core)
> >  
> >  	task_args->bootstrap_start = bootstrap_start;
> -  	task_args->bootstrap_len = restore_bootstrap_len;
> +	task_args->bootstrap_len = restore_bootstrap_len - vdso_rt_size;
> 
> one line fix;)

This is very bad idea. bootstrap_len always supposed to carry the value
of the whole memory slab we need before jumping into pie code. This one
line fix simply mess code even more.


More information about the CRIU mailing list