[CRIU] [PATCH] page-read: add print error in case of bad or corrupted image

Pavel Emelyanov xemul at parallels.com
Tue Nov 19 09:39:22 PST 2013


On 11/19/2013 02:14 PM, Tikhomirov Pavel wrote:
> add it instead of BUG_ON
> we should print error if flag isn't assigned

Missing SOB line.

> @@ -121,7 +126,9 @@ static int read_pagemap_page(struct page_read *pr, unsigned long vaddr, void *bu
>  
>  	if (pr->pe->in_parent) {
>  		pr_debug("\tpr%u Read page %lx from parent\n", pr->id, vaddr);
> -		ret = read_pagemap_page_from_parent(pr->parent, vaddr, buf);
> +		ret = read_pagemap_page_from_parent(pr->parent, vaddr, buf, 0);
> +		if (ret == -1)
> +			return ret;

This is another patch.

>  	} else {
>  		pr_debug("\tpr%u Read page %lx from self %lx/%"PRIx64"\n", pr->id,
>  				vaddr, pr->cvaddr, lseek(pr->fd_pg, 0, SEEK_CUR));
> 




More information about the CRIU mailing list