[CRIU] [PATCH 0/5]v2 work dir

[Andrew Vagin]

On Sat, Nov 16, 2013 at 04:13:29AM +0400, Ruslan Kuprieiev wrote:
> On 15.11.2013 23:37, Andrew Vagin wrote:
> >On Fri, Nov 15, 2013 at 09:49:20PM +0400, Pavel Emelyanov wrote:
> >>On 11/15/2013 11:04 PM, Ruslan Kuprieiev wrote:
> >>>This set of patches will allow us to specifie work directory where
> >>>pidfiles/logs/stats are placed. We will also save one service fd.
> >>>
> >>>Ruslan Kuprieiev (5):
> >>>   crtools: add --work-dir(-W) option
> >>>   image: add dir parameter to open_image_dir()
> >>>   log: get rid of LOG_DIR_FD_OFF and opening cwd in log_init()
> >>>   crtools: chdir to work directory
> >>>   page-server/service: do not chdir / when going daemon
> >>>
> >>>  cr-restore.c        |  1 -
> >>>  cr-service.c        |  6 ++----
> >>>  crtools.c           | 38 ++++++++++++++++++++++++++------------
> >>>  image.c             |  6 +++---
> >>>  include/image.h     |  2 +-
> >>>  include/servicefd.h |  1 -
> >>>  log.c               | 26 ++------------------------
> >>>  page-xfer.c         |  2 +-
> >>>  8 files changed, 35 insertions(+), 47 deletions(-)
> >>>
> >>
> >>OK, applied. One thing to fix on top -- stats files should written to work dir,
> >>not images dir as they are now.
> >Ruslan, you have broken backward compatibility. Pls fix it ASAP.
> >
> >[root at avagin-fc19-cr crtools]# bash test/zdtm.sh -s -i 3 -C static/pipe00
> >================================= CRIU CHECK =================================
> >Looks good.
> >Execute zdtm/live/static/pipe00
> >./pipe00 --pidfile=pipe00.pid --outfile=pipe00.out
> >Dump 2818
> >Dump 2818
> >WARNING: pipe00 returned 255 and left running for debug needs
> >Test: zdtm/live/static/pipe00, Result: FAIL
> >==================================== ERROR ====================================
> >Test: zdtm/live/static/pipe00, Namespace:
> >================================= ERROR OVER =================================
> 
> Hm... Just tried ./zdtm.sh, and looks like all tests are passed. Or
> zdtm could not report about failed test? And again i'm looking at
> pipe00.out and it says "PASS".
> 
> But when i'm trying
>     bash test/zdtm.sh -s -i 3 -C static/pipe00
> it indeed throws an error.
> 
> Maybe the command is wrong? I don't have any clue about zdtm.

It reported PASS before your patches;).

-s: snapshot
-i: Number of snapshots
-C: Clean

Pls, investigate where is a problem

> >>_______________________________________________
> >>CRIU mailing list
> >>CRIU at openvz.org
> >>https://lists.openvz.org/mailman/listinfo/criu
>