[CRIU] [PATCH 0/5]v2 work dir

Andrew Vagin avagin at parallels.com
Fri Nov 15 11:37:59 PST 2013


On Fri, Nov 15, 2013 at 09:49:20PM +0400, Pavel Emelyanov wrote:
> On 11/15/2013 11:04 PM, Ruslan Kuprieiev wrote:
> > This set of patches will allow us to specifie work directory where
> > pidfiles/logs/stats are placed. We will also save one service fd.
> > 
> > Ruslan Kuprieiev (5):
> >   crtools: add --work-dir(-W) option
> >   image: add dir parameter to open_image_dir()
> >   log: get rid of LOG_DIR_FD_OFF and opening cwd in log_init()
> >   crtools: chdir to work directory
> >   page-server/service: do not chdir / when going daemon
> > 
> >  cr-restore.c        |  1 -
> >  cr-service.c        |  6 ++----
> >  crtools.c           | 38 ++++++++++++++++++++++++++------------
> >  image.c             |  6 +++---
> >  include/image.h     |  2 +-
> >  include/servicefd.h |  1 -
> >  log.c               | 26 ++------------------------
> >  page-xfer.c         |  2 +-
> >  8 files changed, 35 insertions(+), 47 deletions(-)
> > 
> 
> 
> OK, applied. One thing to fix on top -- stats files should written to work dir,
> not images dir as they are now.

Ruslan, you have broken backward compatibility. Pls fix it ASAP.

[root at avagin-fc19-cr crtools]# bash test/zdtm.sh -s -i 3 -C static/pipe00
================================= CRIU CHECK =================================
Looks good.
Execute zdtm/live/static/pipe00
./pipe00 --pidfile=pipe00.pid --outfile=pipe00.out
Dump 2818
Dump 2818
WARNING: pipe00 returned 255 and left running for debug needs
Test: zdtm/live/static/pipe00, Result: FAIL
==================================== ERROR ====================================
Test: zdtm/live/static/pipe00, Namespace: 
================================= ERROR OVER =================================

> _______________________________________________
> CRIU mailing list
> CRIU at openvz.org
> https://lists.openvz.org/mailman/listinfo/criu


More information about the CRIU mailing list