[CRIU] [PATCH] LOG_DIR_FD_OFF -> WORK_DIR_FD_OFF

[Ruslan Kuprieiev]

On 12.11.2013 11:34, Pavel Emelyanov wrote:
> On 11/11/2013 03:36 PM, Pavel Emelyanov wrote:
>> On 11/11/2013 07:25 PM, Ruslan Kuprieiev wrote:
>>> On 11.11.2013 15:13, Andrew Vagin wrote:
>>>> On Mon, Nov 11, 2013 at 03:01:07PM +0400, Cyrill Gorcunov wrote:
>>>>> On Mon, Nov 11, 2013 at 02:53:02PM +0400, Pavel Emelyanov wrote:
>>>>>> * service/page-server --daemon
>>>>>> g
>>>>>> - images  : -D, don't start if absent
>>>>>> - logs    : $opt-filename, don't start if not absolute
>>>>>> - pidfiles: $opt-filename, don't start if not absolute
>>>>> Why can't the logs/pidfiles be a relative to -D directory here?
>>>>> Do we really need to require absolute path?
>>>> You think like me :)
>>>>
>>>> But after a discussion I agree that we can have image dir for images
>>>> and work dir for other files like logs, pid, stat???, etc.
>>>>
>>>> I think we need to add an option to customize work dir too.
>>> Maybe for server/service use -D as "work dir" path, and add optional
>>> argument "where to chdir" to -d? For example, if i want server/service
>>> go daemon, put his logs/pidfiles to DIR1 and chdir to DIR2 i will use:
>>> criu service -o logfile --pidfile pidfile -D DIR1 -d DIR2
>> Guys, let's leave -D option alone with "directory for images" meaning only, OK?
>> Ruslan, plz, rework and resend the whole series _as_ _series_ with [PATCH 0/N]
>> to obey the mentioned scheme. If we want the special option for work dir, we'll
>> be able to add one later, but right now I don't see much point in it. All your
>> scenarios can be achieved with the existing options.
> After talking to Andrey and more thinking I came to the conclusion, that backward
> compatibility is still important.
>
> Let's do what was planned with work-dir service fd, options reshuffle and others,
> but then do one more step -- make the work-dir be the same as the image-dir _unless_
> it's overrided with a _new_ command line option. OK?
>
>> Thanks,
>> Pavel
>>
>
Ok. Will add --work-dir(and short -W ?) option.