[CRIU] [PATCH 3/7] don't include crtools.h in pstree.h
Andrew Vagin
avagin at parallels.com
Wed Nov 6 03:34:55 PST 2013
On Wed, Nov 06, 2013 at 03:26:17PM +0400, Pavel Emelyanov wrote:
>
> > @@ -0,0 +1,39 @@
> > +#ifndef __CR_RST_INFO_H__
> > +#define __CR_RST_INFO_H__
> > +
> > +#include "lock.h"
> > +#include "list.h"
> > +
> > +struct fdt {
> > + int nr; /* How many tasks share this fd table */
> > + pid_t pid; /* Who should restore this fd table */
> > + /*
> > + * The fd table is ready for restoing, if fdt_lock is equal to nr
> > + * The fdt table was restrored, if fdt_lock is equal to nr + 1
> > + */
> > + futex_t fdt_lock;
> > +};
> > +
> > +struct rst_info {
> > + struct list_head fds;
> > + struct list_head eventpoll;
> > + struct list_head tty_slaves;
> > +
> > + void *premmapped_addr;
> > + unsigned long premmapped_len;
> > + unsigned long clone_flags;
> > +
> > + void *munmap_restorer;
> > +
> > + int nr_zombies;
> > +
> > + int service_fd_id;
> > + struct fdt *fdt;
> > +
> > + union {
> > + struct pstree_item *pgrp_leader;
> > + futex_t pgrp_set;
> > + };
> > +};
>
> Why not put all this stuff in pstree.h?
Because it must be include in eventpoll.c.
eventpoll and pstree are two different subsystem, I would prefer to
avoid deps between subsystems.
>
> > +#endif
> >
>
>
More information about the CRIU
mailing list