[CRIU] [PATCH 0/8] [v3] Prepare the support for AArch64

[Andrew Vagin]

On Fri, Nov 01, 2013 at 06:40:17PM +0400, Alexander Kartashov wrote:
> On 11/01/2013 05:09 PM, Andrew Vagin wrote:
> >This series breaks the static/cow01 test case.
> >http://10.30.26.89:8080/job/Rpi-CRIU/1914/console
> Page pipe got corrupted while being transfered to the parasite:
> 
> pie: Dumping page pipe:
> pie: 0x8000 4096
> pie: 0x15000 12288
> pie: 0x400ad000 8192
> pie: 0x400b3000 8192
> pie: 0x401e2000 28672
> pie: 0x401ea000 12288
> pie: 0x401ee000 45056
> pie: 0x401fa000 12288
> pie: 0x401fe000 176128
> pie: 0x4022a000 12288
> pie: 0x4022e000 45056
> pie: 0x4023a000 12288
> pie: 0x4023e000 176128
> pie: 0x4026b000 12288
> pie: 0x4026f000 45056
> pie: 0x4027b000 12288
> pie: 0x4027f000 176128
> pie: 0x402ab000 12288
> pie: 0x402af000 45056
> pie: 0x402bb000 12288
> pie: 0x402bf000 176128
> pie: 0x402ed000 12288
> pie: 0x402f1000 45056
> pie: 0x402fd000 12288
> pie: 0x40301000 176128
> pie: 0x4032d000 12288
> pie: 0x40331000 45056
> >>> pie: 0x4033d000 1 <<<
> 
> I'm afraid this issue has nothing to do with this series
> since I've already seen this kind of corruption
> that disappeared mysteriously. Now it's back :(

Looks like we allocate not enough memory for parasite arguments.
A following patch helps me.

diff --git a/parasite-syscall.c b/parasite-syscall.c
index e67b1c3..1d14b48 100644
--- a/parasite-syscall.c
+++ b/parasite-syscall.c
@@ -1152,7 +1152,7 @@ struct parasite_ctl *parasite_infect_seized(pid_t
pid, struct pstree_item *item,
         * without using ptrace at all.
         */
 
-       ctl->args_size = parasite_args_size(vma_area_list, dfds, timer_n);
+       ctl->args_size = parasite_args_size(vma_area_list, dfds, timer_n) + 40960;
        map_exchange_size = parasite_size + ctl->args_size;
        map_exchange_size += RESTORE_STACK_SIGFRAME + PARASITE_STACK_SIZE;
        if (item->nr_threads > 1)

> 
> -- 
> Sincerely yours,
> Alexander Kartashov
> 
> Intern
> Core team
> 
> www.parallels.com
> 
> Skype: aleksandr.kartashov
> Email: alekskartashov at parallels.com
>