[CRIU] [PATCH 0/15] clean up headers (v2)

Andrew Vagin avagin at parallels.com
Mon Nov 4 22:13:15 PST 2013


Pls, don't commit this series. I'm going to resend it in a few minutes.

On Tue, Nov 05, 2013 at 10:00:22AM +0400, Andrey Vagin wrote:
> You don't care about headers, because you don't try to
> build CRIU on Rpi;).
> 
> This series removes restorer.h from unrelated files, restorer.h
> includes too many other headers, so we should avoid its inclusion.
> 
> The main idea of this series is that all headers should be categorized
> * compiler.h, types.h, ...
> * list.h, lock.h, ...
> * util.h, log.h, ...
> * vdso.h, files.h, ...
> * crtools.h
> 
> A header can include only headers from upper levels.
> 
> v2: add servicefd.h and vma.h
>     split crtools.h
> 
> Here are two output if vdso.h is changed.
> Without this patches:
>   CC       parasite-syscall.o
>   CC       cr-restore.o
>   CC       security.o
>   CC       proc_parse.o
>   CC       cr-dump.o
>   CC       cr-check.o
>   CC       ptrace.o
>   CC       shmem.o
>   CC       eventfd.o
>   CC       eventpoll.o
>   CC       mount.o
>   CC       fsnotify.o
>   CC       signalfd.o
>   CC       pstree.o
>   CC       tty.o
>   CC       sigframe.o
>   CC       arch/x86/vdso.o
>   LINK     built-in.o
> 
> With this patches
>   CC       parasite-syscall.o
>   CC       cr-restore.o
>   CC       proc_parse.o
>   CC       cr-dump.o
>   CC       pstree.o
>   CC       arch/x86/vdso.o
>   LINK     built-in.o


More information about the CRIU mailing list