[CRIU] [PATCH 16/21] restore: construct sigframe in crtools

Pavel Emelyanov xemul at parallels.com
Sun May 26 13:29:11 EDT 2013


On 05/26/2013 05:05 PM, Alexander Kartashov wrote:
> On 05/24/2013 04:20 PM, Andrey Vagin wrote:
>> -	if (restore_fpu(sigframe, &rsigframe->fpu_state))
>> -		return -1;
>> +	if (sigframe->fpu_state.has_fpu)
>> +		if (restore_fpu(sigframe, &rsigframe->fpu_state))
>> +			return -1;
> 
> This hunk results in a SEGFAULT in the ARM version crtools
> since the ARM version of the routine restore_fpu()
> accesses the second argument unlike the x86 version
> but the pointer rsigframe is valid in the dumpee address space.
> 
> I'm afraid the routine construct_sigframe() needs redesign.
> 


Andrew, please, help Alexander.


More information about the CRIU mailing list