[CRIU] [PATCH 8/9] vdso: Escape double dumping of rt-vdso if proxy present

Pavel Emelyanov xemul at parallels.com
Fri May 24 05:55:20 EDT 2013


On 05/24/2013 01:47 PM, Cyrill Gorcunov wrote:
> On Fri, May 24, 2013 at 01:32:22PM +0400, Pavel Emelyanov wrote:
>>> +
>>> +		if (parasite_execute(PARASITE_CMD_CHECK_VDSO_MARK, ctl)) {
>>
>> I'm not very happy with going to parasite for every (even pre-checked) vma.
>> Make it in one go to parasite with an array of vmas.
> 
> You mean to walk over all vmas _inside_parasite itsef?

No. Prepare array of vmas to check in crtools, push it into parasite.
Look at how dump-pages + vma-reprotect is done.

>>> +
>>> +		pfn = PME_PFRAME(pfn);
>>> +		BUG_ON(!pfn);
>>
>> You don't need this value for args->is_marked case.
> 
> Yeah, i'll update
> 
> 	Cyrill
> .
> 




More information about the CRIU mailing list