[CRIU] [PATCH 05/13] Add builtin_memcmp, builtin_strcmp helpers

Pavel Emelyanov xemul at parallels.com
Thu May 23 07:35:35 EDT 2013


On 05/23/2013 03:22 PM, Cyrill Gorcunov wrote:
> On Thu, May 23, 2013 at 03:03:19PM +0400, Pavel Emelyanov wrote:
>> On 05/22/2013 11:09 PM, Cyrill Gorcunov wrote:
>>>
>>> Will need them for PIE vdso code.
>>>
>>> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
>>> ---
>>>  arch/arm/include/asm/string.h |  4 ++++
>>>  arch/x86/include/asm/string.h | 33 +++++++++++++++++++++++++++++++++
>>
>> Can we make this more uniform with existing builtin_memcpy?
>> At least wrt code-vs-files layout?
> 
> You mean add implementations to arm?

I mean

1. very tempting to have all memxxx function in one .h file.
2. likely to have them all written in assembly

> The filenames are taken
> from linux kernel, i tried to use same names for us.
> .
> 




More information about the CRIU mailing list