[CRIU] [PATCH 4/5] dump: Escape double dumping of mangled vDSO

Pavel Emelyanov xemul at parallels.com
Mon May 20 08:28:42 EDT 2013


On 05/16/2013 07:33 PM, Cyrill Gorcunov wrote:
> 
> When we dump restored program, if there two vdso present (one -- patched
> old vdso and a new one where calls are redirected to) -- we need to skip
> dumping second vdso. For what we examinate vdso memory with parasite help
> and if special mark present -- we remove such vma from the list.

Then in case of restore on the same kernel again you'd go through proxify
logic again. Why not dump all vmas always, but on restore check what and
how we should proxify?

> Moreover, since we can't rely on [vdso] mark came from procfs parsing,
> we do parse manually all suitable vDSO areas at dumping stage, and
> set/clear VMA_AREA_VDSO status accordingly.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  cr-dump.c                  |  6 ++++
>  include/parasite-syscall.h |  3 ++
>  include/parasite.h         |  9 ++++++
>  parasite-syscall.c         | 75 ++++++++++++++++++++++++++++++++++++++++++++++
>  pie/parasite.c             | 36 ++++++++++++++++++++++
>  5 files changed, 129 insertions(+)
> 




More information about the CRIU mailing list