[CRIU] [PATCH 3/5] vdso: Proxify vDSO code on restore

Pavel Emelyanov xemul at parallels.com
Mon May 20 08:16:24 EDT 2013


On 05/20/2013 04:10 PM, Cyrill Gorcunov wrote:
> On Mon, May 20, 2013 at 04:05:09PM +0400, Pavel Emelyanov wrote:
>> On 05/20/2013 03:58 PM, Cyrill Gorcunov wrote:
>>> On Mon, May 20, 2013 at 03:54:56PM +0400, Pavel Emelyanov wrote:
>>>>
>>>> So you _always_ put VDSO proxy. I thought we've decided not to do it if
>>>> symbols offsets match.
>>>
>>> It's not that simple. I propose to start with always proxy mode
>>> and optimize it after. IOW, always proxy wont hurt, just in some
>>> scenarios we could be more effective.
>>
>> No, I don't want "always proxy" mode. Let's finish reviewing this set, but
>> I will apply one only after "proxy on demand" is ready.
> 
> always proxy mode will be there anyway, proxy on demand is optimization!
> that's why I'm asking for always proxy mode being merged first, then
> we can continue and implement on demand mode.

Proxy mode is task's address space screw up. Let's not affect those users
who don't change kernel and don't want this magic to unpredictably spoil
their software. Please.

> .
> 




More information about the CRIU mailing list