[CRIU] [PATCH 5/6] files: Add c/r for /proc/$pid/ns/$ids references

Pavel Emelyanov xemul at parallels.com
Tue May 14 17:44:35 EDT 2013


On 05/15/2013 01:28 AM, Cyrill Gorcunov wrote:
> On Wed, May 15, 2013 at 01:18:11AM +0400, Pavel Emelyanov wrote:
>>>>
>>>> entry->d points somewhere into the ns_desc_array. What coincidence of circumstances
>>>> can lead to this default: case to occur?
>>>
>>> If we got reference to proc/ns/user. We dont support it yet, 
>>
>> Why? What's wrong with it?
> 
> I didn't looked that much on this stage, all I wanted is to keep
> exsiting functionality at least until the issue with ns procfs
> file opened. Once it works we can extend everything else.
> 
>>> it's valid reference our engine can parse and provide us back a pointer
>>> to array. As only we support it -- we simply drop this case. Another
>>> potential problem -- someone extend array of namspaces but forget to
>>
>> Then we kick this guy's ass.
> 
> It will be late, when program got crashed ;)

We're good at reviewing patches.

> .
> 




More information about the CRIU mailing list