[CRIU] [PATCH] arm: don't touch the field user_regs_struct_t::ARM_ORIG_r0

Alexander Kartashov alekskartashov at parallels.com
Sun May 12 12:55:36 EDT 2013


Dear Chanho,

Does this patch solve the problems you've reported?

On 05/08/2013 04:41 PM, Alexander Kartashov wrote:
> The field user_regs_struct_t::ARM_ORIG_r0 isn't used to prevent
> a syscall restart on ARM unlike x86.
>
> Signed-off-by: Alexander Kartashov <alekskartashov at parallels.com>
> Reported-by: Chanho Park <chanho61.park at samsusng.com>
> ---
>   arch/arm/crtools.c |    3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/arch/arm/crtools.c b/arch/arm/crtools.c
> index b9b2b8b..2338114 100644
> --- a/arch/arm/crtools.c
> +++ b/arch/arm/crtools.c
> @@ -39,9 +39,6 @@ void parasite_setup_regs(unsigned long new_ip, user_regs_struct_t *regs)
>   {
>   	regs->ARM_pc = new_ip;
>   
> -	/* Avoid end of syscall processing */
> -	regs->ARM_ORIG_r0 = -1;
> -
>   	/* Make sure flags are in known state */
>   	regs->ARM_cpsr &= PSR_f | PSR_s | PSR_x | MODE32_BIT;
>   }


-- 
Sincerely yours,
Alexander Kartashov

Intern
Core team

www.parallels.com

Skype: aleksandr.kartashov
Email: alekskartashov at parallels.com



More information about the CRIU mailing list