[CRIU] [PATCH 0/2] make: Add compile time testing for system headers

[Cyrill Gorcunov]

On Wed, May 08, 2013 at 01:48:16PM -0700, Kir Kolyshkin wrote:
>    This one looks already good enough to me. We can improve it as needed.
>    Feel free to use
> 
>    Acked-by: Kir Kolyshkin <kir at openvz.org>
> 
>    Please see some minor nitpicks (which you can definitely ignore) below.

I rather try to address them. Thanks a lot for review!

>   #
>   # Common definitions
>  @@ -112,13 +113,14 @@ build-crtools := -r -R -f scripts/Makefile.build makefile=Makefile.crtools obj
>   PROGRAM                := criu
>  
>   .PHONY: all zdtm test rebuild clean distclean tags cscope      \
>  -       docs help pie protobuf arch/$(ARCH) clean-built
>  +       docs help pie protobuf arch/$(ARCH) clean-built         \
>  +       config
> 
>    I would not add config to phony targets here, it is not even in this
>    file...

Agreed, thanks.

>   #include "protobuf.h"
>   #include "protobuf/tcp-stream.pb-c.h"
>  
>  +#ifndef CONFIG_HAS_TCP_REPAIR
> 
>    Here you could add a comment where you got these definitions from
>    (like /* Taken from netinet/in.h */ or whatever)
>    just in case if we would want to update this later.

Sure.