[CRIU] [PATCH 0/2] make: Add compile time testing for system headers

[Cyrill Gorcunov]

On Tue, May 07, 2013 at 11:26:47PM +0400, Pavel Emelyanov wrote:
> On 05/07/2013 11:14 PM, Cyrill Gorcunov wrote:
> > On Tue, May 07, 2013 at 11:08:37PM +0400, Pavel Emelyanov wrote:
> >> 2 things bother me.
> >>
> >> 1. tcp piggie compilation fail may be not due to structs duplication
> >> 2. code duplication between sk-tcp.c and utilities.mak
> > 
> > At moment we address only name clashes (struct and enums), thus if we
> > need more precise (per-member check or say size of structure check) this
> > facility won't be enough for sure. But I must admit I don't fully understand
> > (1), could you please elaborate?
> 
> I mean "name clash => compilation fail", but the reverse statement is not true,
> while we rely on it.

But the test is exactly for name redefinition detection, nothing more ;)
If compilation fail we will have to investigate what's gone wrong anyway.

> > As to code duplication -- I guess we "could" try to eliminate it -- by providing
> > some header which would be included in both -- utilities,mak and sk-tcp.c.
> > Would this suite you?
> 
> Yes.

OK, i'll try to make it so. Thanks.