[CRIU] [PATCH 0/2] make: Add compile time testing for system headers
Pavel Emelyanov
xemul at parallels.com
Tue May 7 15:08:37 EDT 2013
On 05/03/2013 07:29 PM, Cyrill Gorcunov wrote:
> Hi guys, what do you think about using own 'make' facility for
> testing of system headers definitions and such?
>
> We do generate include/config.h where all the features should lay
> and we can #include it in the places we need.
>
> Vasily, does it fix the problem in Ubuntu 13.04?
>
> Cyrill Gorcunov (2):
> make: Add scripts/utilities.mak
> make: Introduce compile time include/config.h generation
>
> Makefile | 7 +++++--
> Makefile.config | 15 +++++++++++++++
> scripts/feature-tests.mak | 21 +++++++++++++++++++++
> scripts/utilities.mak | 15 +++++++++++++++
> sk-tcp.c | 3 +++
> 5 files changed, 59 insertions(+), 2 deletions(-)
> create mode 100644 Makefile.config
> create mode 100644 scripts/feature-tests.mak
> create mode 100644 scripts/utilities.mak
>
2 things bother me.
1. tcp piggie compilation fail may be not due to structs duplication
2. code duplication between sk-tcp.c and utilities.mak
More information about the CRIU
mailing list