[CRIU] [PATCH 1/2] image: Move image definitions to own file

[Pavel Emelyanov]

On 04/19/2013 12:15 PM, Cyrill Gorcunov wrote:
> 
> To be able to reuse image constants (definitions)
> outside of crtools code I need them yank out to
> own image-defs.[c|h] files.
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov at openvz.org>
> ---
>  Makefile.crtools     |   1 +
>  cr-show.c            |  10 +++++
>  image-defs.c         |  77 +++++++++++++++++++++++++++++++++
>  image.c              |  77 ---------------------------------
>  include/cr-show.h    |  54 ++++++++++++++++++++++++
>  include/crtools.h    | 117 ---------------------------------------------------
>  include/image-defs.h | 105 +++++++++++++++++++++++++++++++++++++++++++++
>  include/image.h      |   1 +
>  8 files changed, 248 insertions(+), 194 deletions(-)
>  create mode 100644 image-defs.c
>  create mode 100644 include/cr-show.h
>  create mode 100644 include/image-defs.h
> 


OK, let's discuss this thing. First -- image-defs.c. It contains the fdset template
array _only_. Thus I'd name it fdset.c, but I don't understand why the rest of fdset
management code sits outside of this file. Don't you need it?

The changes with cr-show.h are OK, I can merge them.

The image-defs.h is the same as the .c one -- it contains parts of fdset API, thus
it's better to name one fdset.h, but yet again -- why only parts?