[CRIU] [PATCH] sk-unix: Print error message if external socket failure happened

Cyrill Gorcunov gorcunov at openvz.org
Tue Mar 26 11:41:20 EDT 2013


On Tue, Mar 26, 2013 at 07:36:02PM +0400, Cyrill Gorcunov wrote:
> On Tue, Mar 26, 2013 at 07:14:25PM +0400, Pavel Emelyanov wrote:
> > > --- a/sk-unix.c
> > > +++ b/sk-unix.c
> > > @@ -432,11 +432,13 @@ int fix_external_unix_sockets(void)
> > >  		BUG_ON(sk->sd.already_dumped);
> > >  
> > >  		if (!opts.ext_unix_sk) {
> > > +			pr_err("External socket found but no option passed\n");
> > 
> > Add info about which exact option is missing.
> 
> Attached.

So you've pushed out update already. Drop this one then.
And please add \n into your commit 21c663dc01f81e2440a19f0e88b8358dc0de78e1
(you converted pr_perror to pr_err but missed to append new line).

/me sigh, will we ever have a commit-bot...


More information about the CRIU mailing list